[SPARK-57917] Fix workload RoleBinding name in operator namespace#739
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-57917] Fix workload RoleBinding name in operator namespace#739dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
Generated-by: Claude Fable 5
Member
Author
Member
Author
|
I merged this bug fix to unblock more features. |
Member
Author
|
Merged to main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the workload
RoleBindingname inworkload-rbac.yamlto use$workloadResources.roleBinding.nameinstead of$workloadResources.serviceAccount.namewhen
workloadResources.namespaces.datais empty, consistent with the per-namespace branch.Why are the changes needed?
The
RoleBindingwas namedspark(the service account name) instead of the intendedspark-workload-rolebinding.Does this PR introduce any user-facing change?
Yes. The
RoleBindingin the operator namespace is now namedspark-workload-rolebindinginstead of
spark.How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5